TASK: Remove Flow's RequestInterface

TLTR: Since the separation of http and cli requests the interface is completely unused. And strict types against its only implementation, the ActionRequest make it impossible to implement a custom request. -------- _Initially_ the interface was introduced with neos/flow-development-collection@39b8f80 at beginning of time. At that time this was done probably to be able to type against the interface instead of the common `Request` class, that the Cli and Web Request both extended. With the removal of many methods in its interface neos/flow-development-collection@8ab6a29 and with the full separation of action and cli requests neos/flow-development-collection#1552 the interface became useless. The dispatcher and controller interface are both typed against the `ActionRequest` and so it's impossible to implement a custom request.
neos · Sep 12, 2024 · 6112ef4 · 6112ef4
1 parent e80ebe7
commit 6112ef4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 68 deletions.
diff --git a/Classes/Mvc/ActionRequest.php b/Classes/Mvc/ActionRequest.php
@@ -26,7 +26,7 @@
  *
  * @api
  */
-class ActionRequest implements RequestInterface
+class ActionRequest
 {
     /**
      * @Flow\Inject

diff --git a/Classes/Mvc/RequestInterface.php b/Classes/Mvc/RequestInterface.php
-Original file line number
+Diff line change
@@ Expand Up / @@ -26,7 +26,7 @@ @@
      *
      * @api
      */
-    class ActionRequest implements RequestInterface
+    class ActionRequest
     {
         /**
          * @Flow\Inject
@@ Expand Down @@