Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed not cache images for full image datamanager #2692

Merged
merged 5 commits into from
Jan 8, 2024
Merged

fixed not cache images for full image datamanager #2692

merged 5 commits into from
Jan 8, 2024

Conversation

hardikdava
Copy link
Contributor

  • skipping cache image for no-cache argument

@maturk
Copy link
Collaborator

maturk commented Dec 23, 2023

@hardikdava, actually, right now the "no-cache" option should not exist and the next_train crashes if "no-cache" is enabled. I think it is better to remove it completely and only have cpu and gpu options.

Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kerrj kerrj merged commit 581ba95 into nerfstudio-project:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants