Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed not cache images for full image datamanager #2692

Merged
merged 5 commits into from
Jan 8, 2024
Merged

fixed not cache images for full image datamanager #2692

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
937675b
fixed bug for cache image
hardikdava Dec 19, 2023
fe164b6
Merge branch 'main' into fix/cache_issue
hardikdava Dec 19, 2023
4fa9631
Merge branch 'main' into fix/cache_issue
maturk Dec 23, 2023
995ed4b
rm no-cache option
maturk Dec 23, 2023
1154db3
Merge branch 'main' into fix/cache_issue
kerrj Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nerfstudio/data/datamanagers/full_images_datamanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ class FullImageDatamanagerConfig(DataManagerConfig):
new images. If -1, never pick new images."""
eval_image_indices: Optional[Tuple[int, ...]] = (0,)
"""Specifies the image indices to use during eval; if None, uses all."""
cache_images: Literal["no-cache", "cpu", "gpu"] = "cpu"
"""Whether to cache images in memory. If "numpy", caches as numpy arrays, if "torch", caches as torch tensors."""
cache_images: Literal["cpu", "gpu"] = "cpu"
"""Whether to cache images in memory. If "cpu", caches on cpu. If "gpu", caches on device."""


class FullImageDatamanager(DataManager, Generic[TDataset]):
Expand Down Expand Up @@ -122,6 +122,7 @@ def __init__(

def cache_images(self, cache_images_option):
cached_train = []
cached_eval = []
CONSOLE.log("Caching / undistorting train images")
for i in tqdm(range(len(self.train_dataset)), leave=False):
# cv2.undistort the images / cameras
Expand Down Expand Up @@ -195,7 +196,6 @@ def cache_images(self, cache_images_option):
self.train_dataset.cameras.cx[i] = float(K[0, 2])
self.train_dataset.cameras.cy[i] = float(K[1, 2])

cached_eval = []
CONSOLE.log("Caching / undistorting eval images")
for i in tqdm(range(len(self.eval_dataset)), leave=False):
# cv2.undistort the images / cameras
Expand Down
Loading