fix: process kill errors on windows with node 21+ #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
force-pushed
the
fix/windows-node-22-eperm-on-kill
branch
from
0240ac4 to
f0ff5e6
Compare
|
|
pieh
force-pushed
the
fix/windows-node-22-eperm-on-kill
branch
4 times, most recently
from
d1de852 to
bc7c0be
Compare
pieh
force-pushed
the
fix/windows-node-22-eperm-on-kill
branch
from
9fc34a3 to
d055d9d
Compare
pieh
changed the title
mrstork
approved these changes
Dec 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
See for underlying problem that so far doesn't seem fixed nodejs/node#51766 . That started showing up on our test runs when Github Actions switched to Node 22 (it was running on 20 before)
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)