Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.6.1 #368

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Prepare 1.6.1 #368

merged 5 commits into from
Jul 16, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 15, 2024

@jotak jotak requested review from msherif1234 and memodi July 15, 2024 07:34
Copy link

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 24.69136% with 122 lines in your changes missing coverage. Please review.

Project coverage is 32.78%. Comparing base (a7056b4) to head (90e1e96).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.6     #368      +/-   ##
===============================================
- Coverage        33.30%   32.78%   -0.52%     
===============================================
  Files               48       48              
  Lines             3492     3596     +104     
===============================================
+ Hits              1163     1179      +16     
- Misses            2232     2316      +84     
- Partials            97      101       +4     
Flag Coverage Δ
unittests 32.78% <24.69%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/pbpacket/packet.pb.go 51.11% <0.00%> (ø)
pkg/ifaces/informer.go 0.00% <0.00%> (ø)
pkg/ifaces/poller.go 82.45% <67.74%> (-10.57%) ⬇️
pkg/ifaces/watcher.go 61.29% <51.35%> (+2.51%) ⬆️
pkg/ebpf/tracer.go 0.00% <0.00%> (ø)

@openshift-ci openshift-ci bot added the lgtm label Jul 15, 2024
@jotak jotak merged commit ec5f257 into netobserv:release-1.6 Jul 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants