NETOBSERV-2107: fix service monitor quotes

[jpinsonneau]

Description

Fix downstream issue when creating service monitor

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@jpinsonneau: This pull request references NETOBSERV-2107 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Description

Fix downstream issue when creating service monitor

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:32aa719

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=32aa719 make commands

or download the updated commands.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.53%. Comparing base (2903037) to head (80d7f2c).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   23.53%   23.53%           
=======================================
  Files          11       11           
  Lines        1330     1330           
=======================================
  Hits          313      313           
  Misses       1000     1000           
  Partials       17       17           

Flag	Coverage Δ
unittests	23.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:1e35507

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=1e35507 make commands

or download the updated commands.

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:65ef205

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=65ef205 make commands

or download the updated commands.

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:be691c8

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=be691c8 make commands

or download the updated commands.

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:328fa27

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=328fa27 make commands

or download the updated commands.

[Amoghrd]

/label qe-approved

[openshift-ci-robot]

@jpinsonneau: This pull request references NETOBSERV-2107 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Description

Fix downstream issue when creating service monitor

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jotak]

not a blocker, but it doesn't make sense to set namespace on a clusterrolebinding (same for clusterrole) - it will work but will be ignored afaik

[jpinsonneau]

Ultimately I would like to rely on Role / RoleBinding here but it doesn't seems to work

Let's keep as is for this release and we'll investigate

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment