Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] NETOBSERV-2107: fix service monitor quotes #167

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

jpinsonneau
Copy link
Contributor

See #166

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 11, 2025

@jpinsonneau: This pull request references NETOBSERV-2107 which is a valid jira issue.

In response to this:

See #166

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

New image:
quay.io/netobserv/network-observability-cli:d7c5545

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=d7c5545 make commands

or download the updated commands.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.53%. Comparing base (f70930d) to head (5b67c47).
Report is 2 commits behind head on release-1.8.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.8     #167   +/-   ##
============================================
  Coverage        23.53%   23.53%           
============================================
  Files               11       11           
  Lines             1330     1330           
============================================
  Hits               313      313           
  Misses            1000     1000           
  Partials            17       17           
Flag Coverage Δ
unittests 23.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

New image:
quay.io/netobserv/network-observability-cli:f0e24cd

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=f0e24cd make commands

or download the updated commands.

Copy link

New image:
quay.io/netobserv/network-observability-cli:3bd68d9

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=3bd68d9 make commands

or download the updated commands.

Copy link

New image:
quay.io/netobserv/network-observability-cli:c9cb636

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=c9cb636 make commands

or download the updated commands.

Copy link

New image:
quay.io/netobserv/network-observability-cli:1587307

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=1587307 make commands

or download the updated commands.

@Amoghrd
Copy link

Amoghrd commented Feb 11, 2025

/label qe-approved

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 11, 2025

@jpinsonneau: This pull request references NETOBSERV-2107 which is a valid jira issue.

In response to this:

See #166

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@memodi: only netobserv org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@memodi
Copy link

memodi commented Feb 11, 2025

/cherry-pick release-4.15

@openshift-cherrypick-robot

@memodi: only netobserv org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@memodi: only netobserv org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@memodi: only netobserv org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9fbccef into netobserv:release-1.8 Feb 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants