fightwarn - nutclient.{h,cpp} : fix an horde of warnings #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimklimov
commented
Nov 25, 2020
jimklimov
added
C++
ready / code review
jimklimov
force-pushed
the
fightwarn-lgtm-com-cxx
branch
from
279f324 to
522f852
Compare
This was referenced Nov 25, 2020
jimklimov
force-pushed
the
fightwarn-lgtm-com-cxx
branch
from
85174c8 to
0ca9faa
Compare
…rnings about C++98 compatibility that we do not claim anyway - check that we have pragmas for that
… warnings about C++98 compatibility that we do not claim anyway - quiesce in C++ source
…global-constructors handling
…global-constructors handling for an std:string static variable
…ses into CPP file to bolt a linker unit (avoid Weak Vtables warnings and related build overheads)
…cially since process exit code is inverted)
…AT_OVERFLOW detection First shot at issue NUT networkupstools#904
…RFLOW detection to quiesce warnings about "%s" resolving from NULL pointer First shot at issue NUT networkupstools#904
…ULL and NUT_STRARG(x) macro (for issue networkupstools#904)
…STIC_IGNORED_GLOBAL_CONSTRUCTORS et al to avoid warnings for CPPUnit macro implementation (boils down to static vars)
jimklimov
force-pushed
the
fightwarn-lgtm-com-cxx
branch
from
0ca9faa to
10677aa
Compare
|
This commit breaks cross-builds: A hackish fix is to add ax_cv__printf_string_null=yes to the configure environment. |
|
Interesting, thanks for the report. Can you clarify the cross-setup you
have (platforms involved, compiler versions, other-platform packages maybe,
configure command line) -- I wonder if I can reproduce it so that CI builds
could care for that case and the main codebase would work with it? I think
we already do somewhat similar to cross-builds in some of Travis
branches... but maybe not enough :)
…On Sun, Mar 21, 2021, 15:25 bkuhls ***@***.***> wrote:
This commit breaks cross-builds:
checking for practical support to pritnf("%s", NULL)... configure: error: in `nut-fbe7806e83f2838da21a0c7d56649777780881c1':
configure: error: cannot run test program while cross compiling
A hackish fix is to add ax_cv__printf_string_null=yes to the configure
environment.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#902 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMPTFHXZ6NE2A332ARNGJ3TEX6WRANCNFSM4UBV42SQ>
.
|
The issue occured while bumping the buildroot package from version 2.7.4 To reproduce the problem use buildroot to build nut with my commit but without https://github.com/bkuhls/buildroot/blob/master_patches/package/nut/nut.mk#L33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a practical fix for #880, at least 50 errors were emitted by clang-9 for the remaining C++ code in this file. Most though not all taste of syntactic sugar, but whatever - if it helps the code be clean and nice.
Follows up from #823 / #844 efforts.