Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fightwarn - nutclient.{h,cpp} : fix an horde of warnings #902

Merged
merged 26 commits into from
Nov 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
11d8818
clients/nutclient.h: align method docs with param names
jimklimov Nov 25, 2020
a40fc26
m4/ax_c_pragmas.m4: for (clang) c++ builds with C++11/17/20, avoid wa…
jimklimov Nov 25, 2020
9f42fdf
clients/nutclient.cpp: for (clang) c++ builds with C++11/17/20, avoid…
jimklimov Nov 25, 2020
ba9d2b4
clients/nutclient.cpp: fix old-style C casts into static_cast<>s
jimklimov Nov 25, 2020
4820684
clients/nutclient.{h,cpp}: align strarr_alloc() type with xcalloc() i…
jimklimov Nov 25, 2020
4aad296
m4/ax_c_pragmas.m4: define pragmas for -Wexit-time-destructors and -W…
jimklimov Nov 25, 2020
b5353cc
clients/nutclient.cpp: use pragmas for -Wexit-time-destructors and -W…
jimklimov Nov 25, 2020
b56a607
clients/Makefile.am: define HAVE_NUTCOMMON for NUT C++ builds
jimklimov Nov 25, 2020
c643daf
clients/nutclient.cpp: quiesce warning and make visible the unused va…
jimklimov Nov 25, 2020
1ebb2c6
clients/nutclient.cpp: (presumed) typo fix - line ended with comma no…
jimklimov Nov 25, 2020
2cfdea9
clients/nutclient.{h,cpp}: move virtual destructors of exception clas…
jimklimov Nov 25, 2020
c1fcda1
clients/Makefile.am: be sure to use NUT libcommon for CXX client builds
jimklimov Nov 25, 2020
b634800
tests/cpputest.cpp: print final result code more comprehensibly (espe…
jimklimov Nov 25, 2020
6ddc24d
m4/ax_c_pragmas.m4: introduce HAVE_PRAGMA_GCC_DIAGNOSTIC_IGNORED_FORM…
jimklimov Nov 25, 2020
b3d777f
tests/nutlogtest.c: use HAVE_PRAGMA_GCC_DIAGNOSTIC_IGNORED_FORMAT_OVE…
jimklimov Nov 25, 2020
60edbb7
m4/ax_c_pragmas.m4, str.h => common.h: introduce HAVE_PRINTF_STRING_N…
jimklimov Nov 25, 2020
34ddafb
tests/nutlogtest.c: add more tests to investigate NUT_STRARG() behaviors
jimklimov Nov 25, 2020
cfe2979
tests/Makefile.am: fix delivery and tracking of CPPUNITTEST(ER)SRC
jimklimov Nov 25, 2020
1f49916
tests/nutclienttest.cpp: fix casting
jimklimov Nov 25, 2020
b85d8bf
tests/nutclienttest.cpp: fix NULL => nullptr
jimklimov Nov 25, 2020
fefcb28
tests/nutclienttest.cpp: fix CPPUNIT assert after nullptr
jimklimov Nov 25, 2020
2d022ba
tests/example.cpp: fix casting
jimklimov Nov 25, 2020
05c5067
tests/*.{c,cpp}: update legaleze headings
jimklimov Nov 25, 2020
232644d
tests/nutclienttest.cpp example.cpp: wrap into HAVE_PRAGMA_GCC_DIAGNO…
jimklimov Nov 25, 2020
10677aa
clients/Makefile.am: AM_CXXFLAGS+=-I$(top_srcdir)/include
jimklimov Nov 26, 2020
d99297c
Merge branch 'master' into fightwarn-lgtm-com-cxx
jimklimov Nov 27, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions clients/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Network UPS Tools: clients
EXTRA_DIST =

# nutclient.cpp for some legacy reason (maybe initial detached development?)
# optionally includes "common.h" with the NUT build setup - and this option
# was never triggered in fact, not until pushed through command line like this:
AM_CXXFLAGS = -DHAVE_NUTCOMMON=1 -I$(top_srcdir)/include

# by default, link programs in this directory with libcommon.a
LDADD = ../common/libcommon.la libupsclient.la $(NETLIBS)
if WITH_SSL
Expand Down Expand Up @@ -67,6 +72,9 @@ if HAVE_CXX11
# libnutclient version information and build
libnutclient_la_SOURCES = nutclient.h nutclient.cpp
libnutclient_la_LDFLAGS = -version-info 1:0:0
# Needed in not-standalone builds with -DHAVE_NUTCOMMON=1
# which is defined for in-tree CXX builds above:
libnutclient_la_LIBADD = $(top_builddir)/common/libcommonclient.la
else
EXTRA_DIST += nutclient.h nutclient.cpp
endif
Loading