Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Added codespell to github action workflow #34

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Conversation

Raya679
Copy link
Contributor

@Raya679 Raya679 commented Aug 7, 2024

Changes proposed in this pull request:

  • Added codespell to github action workflow

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
specious Ildar Sagdejev
@Raya679 Raya679 requested a review from rmanaem August 7, 2024 06:07
@Raya679 Raya679 mentioned this pull request Aug 7, 2024
7 tasks
@rmanaem rmanaem added the pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) label Aug 7, 2024
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Raya679!
I left one suggestion other than that this is good to go 🧑‍🍳

Co-authored-by: Arman Jahanpour <[email protected]>
@Raya679
Copy link
Contributor Author

Raya679 commented Aug 7, 2024

Hii @rmanaem,
I tried using skip: ./app/term_url_processing/abbreviations/* but i think it is not able to recognize that.
Should I go back to how it was previously?

@rmanaem
Copy link
Contributor

rmanaem commented Aug 7, 2024

Looking at their docs I think removing the wild card should do it: https://github.com/codespell-project/codespell?tab=readme-ov-file#usage

try skip: ./app/term_url_processing/abbreviations

@Raya679 Raya679 merged commit 9bc5076 into main Aug 8, 2024
4 checks passed
@Raya679 Raya679 deleted the add-codespell branch August 8, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codespell to github action workflow
2 participants