Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Add major classes/functions to parent namespaces #600

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 6, 2021

Closes #388.

Changes proposed in this pull request:

  • Add major classes and functions to parent module namespaces.

@tsalo tsalo added the refactoring Requesting changes to the code which do not impact behavior label Nov 6, 2021
@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #600 (60def09) into main (bdcec80) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   85.73%   85.76%   +0.02%     
==========================================
  Files          40       40              
  Lines        4382     4390       +8     
==========================================
+ Hits         3757     3765       +8     
  Misses        625      625              
Impacted Files Coverage Δ
nimare/annotate/__init__.py 100.00% <100.00%> (ø)
nimare/decode/__init__.py 100.00% <100.00%> (ø)
nimare/meta/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdcec80...60def09. Read the comment docs.

@tsalo
Copy link
Member Author

tsalo commented Nov 6, 2021

The Sphinx interlinking issue is still there (and apparently has been for a while without me noticing), but the circular import issue seems to be resolved, so I'm going to merge this.

@tsalo tsalo merged commit 0951255 into neurostuff:main Nov 6, 2021
@tsalo tsalo deleted the namespaces branch November 6, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Requesting changes to the code which do not impact behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add main classes/functions to parent namespaces
1 participant