Reorganize and streamline examples #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #656 +/- ##
==========================================
+ Coverage 85.25% 85.29% +0.03%
==========================================
Files 40 40
Lines 4530 4542 +12
==========================================
+ Hits 3862 3874 +12
Misses 668 668
Continue to review full report at Codecov.
|
tsalo
commented
Mar 15, 2022
| # ----------------------------------------------------------------------------- | ||
| from nimare.meta.cbma.ale import ALESubtraction | ||
|
|
||
| meta = ALESubtraction(n_iters=10, n_cores=1) |
There was a problem hiding this comment.
n_cores needs to be 1 because sphinx-gallery can't handle parallelization yet.
tsalo
added a commit
to tsalo/NiMARE
that referenced
this pull request
Mar 21, 2022
This should have been part of neurostuff#656.
tsalo
added a commit
to tsalo/NiMARE
that referenced
this pull request
Mar 21, 2022
Also should have been part of neurostuff#656.
tsalo
added a commit
that referenced
this pull request
Mar 21, 2022
* Standardize example header lengths. * Missed one. * Replace manual conn definition with function. * Convert _calculate_cluster_measures into a function. * Improve spacing and docstring. * Remove unused parameter definition. * Update MKDAChi2 as well. * Add a versionchanged directive for the vfwe_only fix. This should have been part of #656. * Test vfwe_only. Also should have been part of #656.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None. I just thought I'd clean up the examples a bit.
Changes proposed in this pull request:
vfwe_onlyoption inCBMAEstimator.correct_fwe_montecarlo.