Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyborgs: don't drop on down, spawn placeholders on container events #3025

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Mar 4, 2025

About the PR

A fix for cyborg inventory management.

Instead of hand/dropped events, a borg's placeholder item for droppable module slots is spawned on container events (always raised). The placeholder is spawned and placed in the slot at the time of removal.

Additionally, borgs now do not drop their items when downed - their module items should be internal.

Why / Balance

Bug.

How to test

  1. Spawn a service cyborg.
  2. Start another client, become the cyborg, equip the module with the lighter, shaker and book bag.
  3. On the first client, throngle the borg until it drops. It shouldn't drop its items.
  4. Revive the borg. On the second client, drop your droppable items.
  5. Try to pick up the borg's modules and drop them on the first client. You shouldn't get borg placeholders.
  6. Remove the "- type: PreventDropOnDown" line from the cyborg definition.
  7. Repeat 1-3. The borg will still drop its items, but it should have placeholders in their spots.

Media

Requirements

Breaking changes

Changelog

🆑

  • fix: Borgs no longer drop their items when downed, and should spawn a placeholder item whenever a droppable item is removed.

@dvir001 dvir001 self-requested a review March 4, 2025 15:03
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Mar 4, 2025
@dvir001
Copy link
Contributor

dvir001 commented Mar 4, 2025

Should also add PreventDropOnDowned to NF Mob restriction later

@dvir001 dvir001 merged commit 5cef06a into new-frontiers-14:master Mar 4, 2025
16 checks passed
FrontierATC added a commit that referenced this pull request Mar 4, 2025
@whatston3
Copy link
Contributor Author

Should also add PreventDropOnDowned to NF Mob restriction later

Shouldn't need it if you don't have actual hands. Not sure if they do.

@dvir001
Copy link
Contributor

dvir001 commented Mar 4, 2025

Should also add PreventDropOnDowned to NF Mob restriction later

Shouldn't need it if you don't have actual hands. Not sure if they do.

They do, and its glue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants