Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variables in tests #1181

Closed
fallwith opened this issue May 27, 2022 · 3 comments
Closed

Unused variables in tests #1181

fallwith opened this issue May 27, 2022 · 3 comments

Comments

@fallwith
Copy link
Contributor

fallwith commented May 27, 2022

Running our full suite of Minitest tests reports that the following variables are declared but never used. Each test should be verified to see if the variable can be removed entirely or if the test should be refactored to include the use of the variable.

test/new_relic/agent/configuration/server_source_test.rb:139: warning: assigned but unused variable - modified_event_harvest_config
test/new_relic/agent/error_collector_test.rb:353: warning: assigned but unused variable - error
test/new_relic/agent/log_priority_test.rb:12: warning: assigned but unused variable - txn
test/new_relic/agent/span_event_primitive_test.rb:102: warning: assigned but unused variable - external_segment
test/new_relic/dependency_detection_test.rb:212: warning: assigned but unused variable - executed
@workato-integration
Copy link

@ohbarye
Copy link
Contributor

ohbarye commented Oct 12, 2022

I found those warnings listed in #1181 (comment) has already been removed by #1353.

@kaylareopelle
Copy link
Contributor

I'm going to close this issue and open a new one for the latest batch of unused variables in our tests. Thanks for your help, @ohbarye!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants