Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove unused variables in test #1537

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Oct 12, 2022

Overview

A part of #1181 (comment).
This PR addresses warnings thrown by Minitest during test runs related to unused variables.

  1. bundler_version

  2. message

ref https://github.com/newrelic/newrelic-ruby-agent/actions/runs/3228491027/jobs/5284669752

image

Submitter Checklist:

  • Include a link to the related GitHub issue, if applicable
  • Include a security review link, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

1. bundler_version

the local variable has been unused since it's introduced in
8e58861#diff-5c92585b1f81da4bb4c96bff0e84e668725467ce36ed0b1915c68e866c50bbfdR140

2. message

the local variable has been unused since it's introduced in
1dd1650#diff-5c92585b1f81da4bb4c96bff0e84e668725467ce36ed0b1915c68e866c50bbfdR688
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Oct 12, 2022
@fallwith
Copy link
Contributor

Hi @ohbarye. Thank you very much for the cleanup that your contribution provides! This will help a lot as we continue to refactor and lint things in the project. It's good to know that the code in front of us is actually being used and to have the unused content removed.

@fallwith fallwith merged commit 7307d8d into newrelic:dev Oct 12, 2022
@ohbarye ohbarye deleted the remove-unused-variables-in-tests branch October 13, 2022 00:06
@ohbarye
Copy link
Contributor Author

ohbarye commented Oct 13, 2022

Thanks for your quick review! I'll try to meaningfully contribute more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants