-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoMethod error raised from redis instrumentation when queueing ActiveJob sidekiq job #1639
Comments
Hi @fcheung, thanks for bringing this to our attention. We're taking a look at the problem and hope to have more info for you soon. |
Hi @fcheung, we're triaging this bug. Thanks for bringing it to our attention and providing the reproduction! To confirm, is this error crashing your application or your agent? While we're working on a solution, we wanted to share some options with you to prevent the error until we find a solution:
cc: @stevenou |
It’s an application crash - anything that enqueues an activejob, for example trying to send an email. I’ve rolled back to 8.12 for now |
Thanks for clarifying, @fcheung! |
@fcheung @stevenou - We have a PR open with a potential fix for this bug. This can be tested by replacing your Gemfile entry for gem 'newrelic_rpm', git: 'https://github.com/newrelic/newrelic-ruby-agent.git', branch: 'bugfix/redisclient_undefined_method_db' If you choose to test this out, we'd love to hear how it goes. |
I only have this problem in dev, not production, so my testing is limited - but the PR appears to resolve the issue. |
added a regression test for #1639 that reproduces the issue of being unable to call `(self.)client.db` when `(self.)client` returns an instance of `RedisClient` and not `Redis::Client`
Looks good in my dev environment. |
Hi @fcheung and @stevenou. Thank you both again for working with us to get this bug resolved. We just released v8.13.1 of the Ruby agent, which wraps up this issue. Cheers! |
Description
When enqueueing a job I get an error with this backtrace
Expected Behavior
No exception should be raised
Steps to Reproduce
This script reproduces the issue for me. requires REDIS_URL to be set ( eg
redis://127.0.0.1:6379/0
Your Environment
ruby 3.1.2
Gem versions:
Redis is the
redis:6.2-alpine
docker image, running locally. Everything works fine if I downgrade to newrelic 8.12, or downgrade the redis gem to 4.8For Maintainers Only or Hero Triaging this bug
Suggested Priority (P1,P2,P3,P4,P5):
Suggested T-Shirt size (S, M, L, XL, Unknown):
The text was updated successfully, but these errors were encountered: