Call client.config instead of client #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
force-pushed
the
bugfix/redisclient_undefined_method_db
branch
from
2e9de9e to
a15a5ea
Compare
In some cases, the client object cannot directly access methods like db, port, or path. These methods are always available on the client.config object.
fallwith
force-pushed
the
bugfix/redisclient_undefined_method_db
branch
from
a15a5ea to
9d4d175
Compare
added a regression test for #1639 that reproduces the issue of being unable to call `(self.)client.db` when `(self.)client` returns an instance of `RedisClient` and not `Redis::Client`
fallwith
previously approved these changes
Nov 17, 2022
tannalynn
reviewed
Nov 17, 2022
place the Sidekiq/Redis test class in its proper location
SimpleCov Report
|
improve the skipping logic - don't perform a Ruby version check to artificially limit the number of environments that will conduct the test. the test is not Ruby version dependent, but is also not particularly slow. let it run everywhere. - make the skip logic more clear, both in how the code itself flows and the reasoning behind it as it pertains to informing readers about the reproduction of the bug
tannalynn
previously approved these changes
Nov 17, 2022
update the v8.13.0 changelog entry to point Sidekiq v7.0 users to v8.13.1 of the agent [skip ci]
tannalynn
approved these changes
Nov 17, 2022
|
reminder: this bugfix branch has been mentioned publicly and should not be deleted until after v8.13.1 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In some cases, the RedisClient object cannot directly access methods like db, port, or path. These methods are always available on the client.config object.
Resolves: #1639
Submitter Checklist:
Include a security review link, if applicableTesting
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist