-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Removed children from segments. #2689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
force-pushed
the
remove-child-segments
branch
from
October 31, 2024 15:17
d1383c6
to
e45d857
Compare
bizob2828
changed the title
Remove child segments
feat: Removed children from segments.
Oct 31, 2024
bizob2828
force-pushed
the
remove-child-segments
branch
from
October 31, 2024 15:29
e45d857
to
8a8c5e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2689 +/- ##
===========================================
+ Coverage 79.12% 97.31% +18.18%
===========================================
Files 281 291 +10
Lines 45230 46309 +1079
===========================================
+ Hits 35790 45065 +9275
+ Misses 9440 1244 -8196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
previously approved these changes
Oct 31, 2024
jsumners-nr
approved these changes
Oct 31, 2024
bizob2828
added a commit
that referenced
this pull request
Oct 31, 2024
bizob2828
added a commit
that referenced
this pull request
Oct 31, 2024
bizob2828
added a commit
that referenced
this pull request
Nov 7, 2024
bizob2828
added a commit
that referenced
this pull request
Nov 7, 2024
bizob2828
added a commit
that referenced
this pull request
Nov 8, 2024
bizob2828
added a commit
that referenced
this pull request
Nov 8, 2024
bizob2828
added a commit
that referenced
this pull request
Nov 13, 2024
bizob2828
added a commit
that referenced
this pull request
Nov 19, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 4, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 9, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 12, 2024
jsumners-nr
pushed a commit
to jsumners-nr/node-newrelic
that referenced
this pull request
Dec 13, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 13, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 16, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 19, 2024
bizob2828
added a commit
that referenced
this pull request
Jan 13, 2025
bizob2828
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes storing a segments children on the segment itself. Instead I've introduced a segments property on the transaction trace and added parentId to every segment. This will build the tree of segments when we serialize the trace but also get the children of a segment when we calculate the exclusive time. I'd like to improve the code in a follow up to only generate the tree for a segment once which will introduce some sort of linked list. I also want to remove storing the root segment on every segment and instead store this in the context manager
Related Issues
Closes #2657