-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge staged otel work #2873
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2873 +/- ##
==========================================
+ Coverage 97.27% 97.35% +0.08%
==========================================
Files 296 308 +12
Lines 46560 47369 +809
==========================================
+ Hits 45289 46116 +827
+ Misses 1271 1253 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No merge conflicts, and tests are passing = 👍
Description
Please provide a brief description of the changes introduced in this pull request.
What problem does it solve? What is the context of this change?
This PR merges the work that has been in flight to support the opentelemetry bridge. The big changes are the context manager now stores the segment separate from the transaction. Also segments no longer store their children. Lastly there's code to synthesize segments from Otel spans but none of that code is hooked into the agent yet.
How to Test
Please describe how you have tested these changes. Have you run the code against an example application?
What steps did you take to ensure that the changes are working correctly?
For changelog:
shim.createSegment
andshim.handleMqTracingHeaders
to be backwards compatible with the changes to context manager (fix: Updatedshim.createSegment
andshim.handleMqTracingHeaders
to be backwards compatible with the changes to context manager #2844)