Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stops calling send() on streaming span aggregator on initial harvest. #622

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Stops calling send() on streaming span aggregator on initial harvest. #622

merged 1 commit into from
Feb 23, 2021

Conversation

michaelgoin
Copy link
Member

@michaelgoin michaelgoin commented Feb 19, 2021 •
edited
Loading

Proposed Release Notes

  • Removed initial harvest send() call on streaming span event aggregator to prevent warning in logs.

Links

Details

Longer-term, would be nice if the code was restructured so we didn't need to check for streaming VS non streaming but going with the minimal effort for now.

@michaelgoin michaelgoin added risk: low This change does not impact critical areas of the code and is expected to have minimal risk. semver: patch Backwards compatible fixes. labels Feb 19, 2021
carlo-808
carlo-808 approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@carlo-808 carlo-808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Added a check for streaming span aggregator to gate to aggregator.send().

@carlo-808 carlo-808 merged commit 02e0e45 into newrelic:main Feb 23, 2021
@michaelgoin michaelgoin deleted the stop-streaming-send-call branch February 23, 2021 19:43
@michaelgoin michaelgoin mentioned this pull request Feb 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlo-808 carlo-808 carlo-808 approved these changes

Assignees
No one assigned
Labels
risk: low This change does not impact critical areas of the code and is expected to have minimal risk. semver: patch Backwards compatible fixes.
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelgoin @carlo-808