Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release #628

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Prepare release #628

merged 2 commits into from
Feb 23, 2021

Conversation

michaelgoin
Copy link
Member

Proposed Release Notes

  • Fixed bug where the agent failed to reconnect to Infinite Tracing gRPC streams on Status OK at higher log levels.

    Node streams require all data be consumed for the end/status events to fire. We were only reading data at lower log levels where we'd use/log the data. This resulted in a failure to reconnect and 'ERR_STREAM_WRITE_AFTER_END' errors. The agent now always listens to the 'data' event, even if not logging, and will also reconnect (with 15 second delay) on any 'ERR_STREAM_WRITE_AFTER_END' error.

  • Removed initial harvest send() call on streaming span event aggregator to prevent warning in logs.

  • Bumped @newrelic/aws-sdk to ^3.1.0.

Links

Details

@michaelgoin michaelgoin added risk: low This change does not impact critical areas of the code and is expected to have minimal risk. semver: patch Backwards compatible fixes. labels Feb 23, 2021
Copy link
Contributor

@carlo-808 carlo-808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@carlo-808 carlo-808 merged commit b7a9fc6 into newrelic:main Feb 23, 2021
@michaelgoin michaelgoin deleted the prepare-release branch February 23, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk: low This change does not impact critical areas of the code and is expected to have minimal risk. semver: patch Backwards compatible fixes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants