Update how histogram&summary metrics are reported #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As New Relic is improving its support for Prometheus native format, we could change the way how we report Summary and Histogram metric types and do it in less disruptive way, meaning that we send them as they come from Prometheus, without adding custom suffixes or calculating percentiles from the integration side. These are the details of the current implementation: - xxx_bucket is ingested as a Counter (converted to a delta rather than accumulative). Metrics containing dimension "le" == '+Inf' are also sent, we don't omit them. - xxx_count is passed through as a Counter (converted to a delta rather than accumulative). - xxx_total passed through as a Counter (converted to a delta rather than accumulative). - xxx_sum is passed through as a NR Summary converted to a delta rather than accumulative, Min and Max here should be NaN. Its value can be negative. The count field of the summary should be 1. - For Prometheus summary metrics, we report the quantile as a dimension and we don't add a "percentile" dimension.
areina
force-pushed
the
new-summary-and-histograms
branch
from
6ea02b8 to
0250ae2
Compare
alejandrodnm
approved these changes
Jun 22, 2020
This was referenced Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As New Relic is improving its support for Prometheus native format, we
could change the way how we report Summary and Histogram metric types
and do it in less disruptive way, meaning that we send them as they come
from Prometheus, without adding custom suffixes or calculating
percentiles from the integration side.
These are the details of the current implementation:
accumulative). Metrics containing dimension "le" == '+Inf' are also
sent, we don't omit them.
than accumulative, Min and Max here should be NaN. Its value can be negative.
The count field of the summary should be 1.
and we don't add a "percentile" dimension.
This is an important breaking change so we would need to manage carefully the new release of the integration. It should be a new major version, and I think we would need to have a beta version before releasing a 2.0.0 version.