Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes storybook-native debugger by upgrading react native #673

Merged
merged 15 commits into from
Feb 23, 2018
Merged

fix: fixes storybook-native debugger by upgrading react native #673

merged 15 commits into from
Feb 23, 2018

Conversation

nikhedonia
Copy link
Contributor

@nikhedonia nikhedonia commented Feb 20, 2018 •
edited
Loading

Fixes the storybook debugger on iOS and Android by upgrading to [email protected] and [email protected]

After installing make sure you clear your cache:

watchman watch-del-all
yarn cache clean
git clean -xdf
rm -rf $TMPDIR/haste-map-react-native-packager-*
rm -rf $TMPDIR/react-*

ToDo:

  • test on osx
  • test on linux
  • fix brightcove's failing tests
  • get svg working
    • on osx
    • on android

References:

facebook/react-native#6627
react-navigation/react-navigation#2387

kaliabadi
kaliabadi previously requested changes Feb 22, 2018
View reviewed changes
android/app/src/main/assets/index.android.bundle Outdated
@@ -0,0 +1,13 @@
var __DEV__=false,__BUNDLE_START_TIME__=this.nativePerformanceNow?nativePerformanceNow():Date.now(),process=this.process||{};process.env=process.env||{};process.env.NODE_ENV='production';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think we want to include the bundle/meta bundle

kaliabadi
kaliabadi reviewed Feb 22, 2018
View reviewed changes
android/app/src/main/assets/index.android.bundle.meta Outdated
@@ -0,0 +1 @@
=_[/8�n�c�˻f�Ĭ�2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs removing

@craigbilner craigbilner merged commit 2228d33 into master Feb 23, 2018
@craigbilner craigbilner deleted the feat/react-native-53 branch February 23, 2018 10:29
@nikhedonia nikhedonia removed the WIP label Feb 23, 2018
@nikhedonia nikhedonia mentioned this pull request Mar 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaliabadi kaliabadi kaliabadi left review comments

@craigbilner craigbilner craigbilner approved these changes

@jimhunty jimhunty Awaiting requested review from jimhunty

@colincclark colincclark Awaiting requested review from colincclark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhedonia @kaliabadi @craigbilner