Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes storybook-native debugger by upgrading react native #673

Merged
merged 15 commits into from
Feb 23, 2018
Merged

fix: fixes storybook-native debugger by upgrading react native #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
948b3b2
fix: fixes storybook-native debugger by upgrading react native
nikhedonia Feb 20, 2018
9fb9e02
chore: updates brightcove snapshots
nikhedonia Feb 20, 2018
aeca8c2
fix: update storybook to 3.3.14 to fix ws issue
nikhedonia Feb 21, 2018
d6c757c
chore: updates yarn.lock
nikhedonia Feb 21, 2018
d799281
chore: updates react-native-svg
nikhedonia Feb 21, 2018
0b762e8
fix: fixes images and gradient
nikhedonia Feb 21, 2018
8021185
fix: rouge stylesheet in slice
nikhedonia Feb 21, 2018
a08585a
chore: updates snapshots in brightcove-video
nikhedonia Feb 21, 2018
988bccb
fix: ios build
nikhedonia Feb 21, 2018
b2d916b
fix: ios build
nikhedonia Feb 21, 2018
5e85d7a
chore: update snapshots
nikhedonia Feb 21, 2018
c40e0b0
chore: updates readme
nikhedonia Feb 21, 2018
2ec4058
cleanup: remove the android meta bundle
nikhedonia Feb 22, 2018
3ebcc40
fix: revert xcodeproj
nikhedonia Feb 22, 2018
b459df4
chore: removes android android.bundle.mete
nikhedonia Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"presets": ["react-native"],
"presets": ["env", "react-native"],
"plugins": [["flow-react-proptypes", { "ignoreNodeModules": true }]]
}
13 changes: 13 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,19 @@ You can try without these requirements, but you'd be on your own.
work.
4. go to http://localhost:7007

## React-Native Remote Debugger

The current React-Native version opens the url `10.0.0.2:8081` when remote
debugging is enabled. This only works if this ip redirects to `localhost`.

In order to remote debug react native app on via `localhost` you need to follow
this particular sequence:

1. `yarn storybook`
2. navigate to `localhost:8081/debugger-ui`
3. `yarn android` or `yarn ios`
* if android: `cmd+M` and enable Remote Debugging

### Fonts ⚠️

In order to view the storybook on native, you'll need to fix broken fonts. This
Expand Down
2 changes: 1 addition & 1 deletion android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ dependencies {
exclude group: "com.google.android.gms"
}
implementation project(path: ':rntbrightcovevideo')
implementation "com.facebook.react:react-native:0.50.1" // From node_modules
implementation "com.facebook.react:react-native:0.53.+" // From node_modules
implementation "com.facebook.stetho:stetho:1.5.0"
}

Expand Down
33 changes: 8 additions & 25 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,13 @@
},
"homepage": "https://github.com/newsuk/times-components#readme",
"devDependencies": {
"@storybook/addon-actions": "3.3.11",
"@storybook/addon-info": "3.3.11",
"@storybook/addon-options": "3.3.11",
"@storybook/addon-knobs": "3.3.13",
"@storybook/addons": "3.3.11",
"@storybook/react": "3.3.11",
"@storybook/react-native": "3.3.11",
"@storybook/addon-actions": "3.3.14",
"@storybook/addon-info": "3.3.14",
"@storybook/addon-options": "3.3.14",
"@storybook/addon-knobs": "3.3.14",
"@storybook/addons": "3.3.14",
"@storybook/react": "3.3.14",
"@storybook/react-native": "3.3.14",
"@times-components/fructose": "3.1.14",
"babel-core": "6.26.0",
"babel-plugin-flow-react-proptypes": "14.0.3",
Expand Down Expand Up @@ -136,7 +136,7 @@
"prop-types": "15.6.0",
"react": "16.2.0",
"react-dom": "16.2.0",
"react-native": "0.50.1",
"react-native": "0.53.3",
"react-native-storybook-loader": "1.5.1",
"react-native-web": "0.3.2",
"rimraf": "2.6.1",
Expand All @@ -149,22 +149,5 @@
"dependencies": {
"babel-preset-env": "1.6.1",
"babel-preset-stage-2": "6.24.1"
},
"resolutions": {
"@storybook/addon-actions": "3.3.11",
"@storybook/addon-info": "3.3.11",
"@storybook/addon-links": "3.3.11",
"@storybook/addons": "3.3.11",
"@storybook/channels": "3.3.11",
"@storybook/channel-websocket": "3.3.11",
"@storybook/react": "3.3.11",
"@storybook/react-native": "3.3.11",
"@storybook/channel-postmessage": "3.3.11",
"@storybook/components": "3.3.11",
"@storybook/client-logger": "3.3.11",
"@storybook/node-logger": "3.3.11",
"@storybook/ui": "3.3.11",
"react-native": "0.50.1",
"ws": "3.3.2"
}
}
7 changes: 4 additions & 3 deletions packages/ad/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
},
"homepage": "https://github.com/newsuk/times-components#readme",
"devDependencies": {
"@storybook/addon-actions": "3.3.11",
"@storybook/react-native": "3.3.11",
"@storybook/addon-actions": "3.3.14",
"@storybook/react-native": "3.3.14",
"@times-components/eslint-config-thetimes": "0.1.3",
"@times-components/utils": "0.5.1",
"dextrose": "^1.4.6",
Expand All @@ -54,7 +54,8 @@
"prettier": "1.8.2",
"react": "16.2.0",
"react-dom": "16.2.0",
"react-native": "0.50.1",
"react-native": "0.53.3",
"react-stateful-fn": "0.1.0",
"react-test-renderer": "16.2.0"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/article-byline/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"homepage": "https://github.com/newsuk/times-components#readme",
"devDependencies": {
"@storybook/react-native": "3.3.11",
"@storybook/react-native": "3.3.14",
"@times-components/eslint-config-thetimes": "0.1.3",
"@times-components/jest-configurator": "0.2.1",
"dextrose": "^1.4.6",
Expand All @@ -42,7 +42,7 @@
"raf": "3.4.0",
"react": "16.2.0",
"react-dom": "16.2.0",
"react-native": "0.50.1",
"react-native": "0.53.3",
"react-native-web": "0.3.2",
"react-test-renderer": "16.2.0"
},
Expand Down
8 changes: 4 additions & 4 deletions packages/article-flag/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"homepage": "https://github.com/newsuk/times-components#readme",
"devDependencies": {
"@storybook/react-native": "3.3.11",
"@storybook/react-native": "3.3.14",
"@times-components/eslint-config-thetimes": "0.1.3",
"@times-components/jest-configurator": "0.2.1",
"dextrose": "^1.4.6",
Expand All @@ -41,14 +41,14 @@
"prettier": "1.8.2",
"react": "16.2.0",
"react-dom": "16.2.0",
"react-native": "0.50.1",
"react-native": "0.53.3",
"react-test-renderer": "16.2.0"
},
"dependencies": {
"@times-components/icons": "0.1.15",
"prop-types": "15.6.0",
"react-native-svg": "5.5.0",
"svgs": "3.1.1"
"react-native-svg": "5.5.1",
"svgs": "3.2.1"
},
"peerDependencies": {
"babel-preset-env": "1.6.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/article-image/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"homepage": "https://github.com/newsuk/times-components#readme",
"devDependencies": {
"@storybook/react-native": "3.3.11",
"@storybook/react-native": "3.3.14",
"@times-components/eslint-config-thetimes": "0.1.3",
"@times-components/jest-configurator": "0.2.1",
"@times-components/utils": "0.5.1",
Expand All @@ -44,7 +44,7 @@
"prettier": "1.8.2",
"react": "16.2.0",
"react-dom": "16.2.0",
"react-native": "0.50.1",
"react-native": "0.53.3",
"react-native-web": "0.3.2",
"react-test-renderer": "16.2.0"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/article-label/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"prop-types": "15.6.0"
},
"devDependencies": {
"@storybook/addon-knobs": "3.3.13",
"@storybook/react-native": "3.3.11",
"@storybook/addon-knobs": "3.3.14",
"@storybook/react-native": "3.3.14",
"@times-components/eslint-config-thetimes": "0.1.3",
"@times-components/jest-configurator": "0.2.1",
"@times-components/storybook": "0.4.1",
Expand All @@ -50,7 +50,7 @@
"prettier": "1.8.2",
"react": "16.2.0",
"react-dom": "16.2.0",
"react-native": "0.50.1",
"react-native": "0.53.3",
"react-native-web": "0.3.2",
"react-test-renderer": "16.2.0"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/article-summary/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@
},
"homepage": "https://github.com/newsuk/times-components#readme",
"devDependencies": {
"@storybook/react-native": "3.3.11",
"@storybook/react-native": "3.3.14",
"@times-components/eslint-config-thetimes": "0.1.3",
"dextrose": "^1.4.6",
"eslint": "4.9.0",
"jest": "21.2.1",
"prettier": "1.8.2",
"react": "16.2.0",
"react-dom": "16.2.0",
"react-native": "0.50.1",
"react-native": "0.53.3",
"react-native-web": "0.3.2",
"react-test-renderer": "16.2.0"
},
Expand Down
9 changes: 9 additions & 0 deletions packages/article/__tests__/ios/__snapshots__/related-article.ios.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ exports[`Related articles test on ios Related articles renders single related ar
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -417,6 +418,7 @@ exports[`Related articles test on ios Related articles renders single related ar
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -739,6 +741,7 @@ exports[`Related articles test on ios Related articles renders single related ar
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -1040,6 +1043,7 @@ exports[`Related articles test on ios Related articles renders single related ar
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -1271,6 +1275,7 @@ exports[`Related articles test on ios Related articles renders three related art
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -1543,6 +1548,7 @@ exports[`Related articles test on ios Related articles renders three related art
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -1815,6 +1821,7 @@ exports[`Related articles test on ios Related articles renders three related art
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -2145,6 +2152,7 @@ exports[`Related articles test on ios Related articles renders two related artic
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -2417,6 +2425,7 @@ exports[`Related articles test on ios Related articles renders two related artic
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down
8 changes: 4 additions & 4 deletions packages/article/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
},
"homepage": "https://github.com/newsuk/times-components#readme",
"devDependencies": {
"@storybook/addon-actions": "3.3.11",
"@storybook/addons": "3.3.11",
"@storybook/react-native": "3.3.11",
"@storybook/addon-actions": "3.3.14",
"@storybook/addons": "3.3.14",
"@storybook/react-native": "3.3.14",
"@times-components/eslint-config-thetimes": "0.1.3",
"@times-components/jest-configurator": "0.2.1",
"@times-components/tealium": "0.2.6",
Expand All @@ -49,7 +49,7 @@
"prettier": "1.8.2",
"react": "16.2.0",
"react-dom": "16.2.0",
"react-native": "0.50.1",
"react-native": "0.53.3",
"react-native-web": "0.3.2",
"react-test-renderer": "16.2.0",
"styled-components": "2.2.3"
Expand Down
10 changes: 5 additions & 5 deletions packages/author-head/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
},
"homepage": "https://github.com/newsuk/times-components#readme",
"devDependencies": {
"@storybook/addon-actions": "3.3.11",
"@storybook/addons": "3.3.11",
"@storybook/react-native": "3.3.11",
"@storybook/addon-actions": "3.3.14",
"@storybook/addons": "3.3.14",
"@storybook/react-native": "3.3.14",
"@times-components/eslint-config-thetimes": "0.1.3",
"@times-components/jest-configurator": "0.2.1",
"@times-components/storybook": "0.4.1",
Expand All @@ -58,7 +58,7 @@
"prettier": "1.8.2",
"react": "16.2.0",
"react-dom": "16.2.0",
"react-native": "0.50.1",
"react-native": "0.53.3",
"react-native-web": "0.3.2",
"react-test-renderer": "16.2.0"
},
Expand All @@ -72,7 +72,7 @@
"@times-components/tracking": "0.7.6",
"prop-types": "15.6.0",
"styled-components": "2.2.3",
"svgs": "3.1.1"
"svgs": "3.2.1"
},
"peerDependencies": {
"babel-preset-env": "1.6.1",
Expand Down
8 changes: 8 additions & 0 deletions packages/author-profile/__tests__/ios/__snapshots__/author-profile.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,7 @@ exports[`AuthorProfile test on ios renders profile 1`] = `
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -1647,6 +1648,7 @@ exports[`AuthorProfile test on ios renders profile 1`] = `
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -2187,6 +2189,7 @@ exports[`AuthorProfile test on ios renders profile content component 1`] = `
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -2434,6 +2437,7 @@ exports[`AuthorProfile test on ios renders profile content component 1`] = `
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -2681,6 +2685,7 @@ exports[`AuthorProfile test on ios renders profile content component 1`] = `
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -3276,6 +3281,7 @@ exports[`AuthorProfile test on ios renders profile content item component 1`] =
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -3377,6 +3383,7 @@ exports[`AuthorProfile test on ios renders profile content item component with a
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down Expand Up @@ -3478,6 +3485,7 @@ exports[`AuthorProfile test on ios renders profile content item component with n
accessibilityTraits={undefined}
accessible={true}
collapsable={undefined}
hasTVPreferredFocus={undefined}
hitSlop={undefined}
isTVSelectable={true}
nativeID={undefined}
Expand Down
Loading