Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL + ENTER to Save Changes on Card Description #3268

Closed
SethFalco opened this issue Aug 22, 2021 · 4 comments · Fixed by #3774
Closed

CTRL + ENTER to Save Changes on Card Description #3268

SethFalco opened this issue Aug 22, 2021 · 4 comments · Fixed by #3774

Comments

@SethFalco
Copy link

SethFalco commented Aug 22, 2021

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

In many apps doing CTRL + ENTER acts as a "finished" action to either send, post, or save whatever the user is typing.

For example:

  • To send an email in Tutanota.
  • Submitting issues, pull requests, and comments on GitHub.
  • Commenting on Reddit.
  • Tweeting on Twitter.

Describe the solution you'd like

After clicking "Edit description" the user can type to edit the description of a card.
I think if a user does CTRL + ENTER it should act as if the user clicked "View description". (Save and return to the non-edit view.)

Describe alternatives you've considered

N/A

Additional context

Moved over from stefan-niedermann/nextcloud-deck#1087

@stefan-niedermann
Copy link
Member

Related to #46

@dodedodo
Copy link

I think CTRL + S would make more sense in this case. You're not sending or submitting a message like in a mail client or twitter, but rather saving a description.

CTRL + ENTER would make sense for comments.

@SethFalco
Copy link
Author

I think CTRL + ENTER makes more sense, since CTRL + S usually doesn't affect the view.
I'm not asking to only save the content of the description, I'm suggesting this should kick the user out of the "Edit description" view entirely.

This is likely subjective, however. In the end, I'm down for whatever most users are into.

@Ben-Ro
Copy link
Contributor

Ben-Ro commented Apr 30, 2022

Hey all,
this missing feature annoyed me for some time, so i decided to implement it.

It uses Keylisteners on easymde.codemirror. Once the CMD/CTRL is pressed, it sets keyExitState = 1 until the key is released. If Enter is pushed while this, it calls hideEditor() (just like the Action Button) and removes all Keylisteners.

I just create a Pull Request, i hope the code quality is ok :)

juliusknorr pushed a commit to Ben-Ro/deck that referenced this issue Oct 19, 2022
juliusknorr added a commit that referenced this issue Oct 19, 2022
…_on_Card_Description

feat: #3268 CTRL/CMD + ENTER to Save Changes on Card Description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants