-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #3268 CTRL/CMD + ENTER to Save Changes on Card Description #3774
feat: #3268 CTRL/CMD + ENTER to Save Changes on Card Description #3774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution. I've added a small suggestion to avoid the timeout inline, otherwise this looks good to me 👍
src/components/card/Description.vue
Outdated
@@ -175,8 +176,33 @@ export default { | |||
} | |||
this.descriptionEditing = true | |||
this.description = this.card.description | |||
|
|||
// Has to start after the Editor is fully loaded. This shouldn't take longer than 1/4 second | |||
setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid the setTimeout you could also register this on a callback of the initialized event that the VueEasyMDE component emits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, i just added a method that's called via @initialized
. The Code inside the function is exactly the same as in the previous version :)
fbd0e9e
to
9342d8a
Compare
9342d8a
to
ec25077
Compare
ec25077
to
3af54d7
Compare
Thanks a lot for your pull request and I'm very sorry for taking so long to merge. |
I'm using Deck 1.8.3 but it seems that Can someone confirm if they have the same issue or if this broke at some point? |
Hey, which OS and Browser are you usign? If you're on a mac the shortcut would be |
I'm on Debian 11 (Linux), worth noting I use this same shortcut everywhere else (including to post this comment) and it works fine. 😭 |
CTRL/CMD + ENTER to Save Changes on Card Description
fixes #3268
Signed-off-by: ben [email protected]
CTRL
+ENTER
to Save Changes on Card Description #3268Summary
Allows saving and leaving the Card Description Editor via
CTRL
/CMD
+ENTER
. It's the same shortcut as with Twitter, Trello, Github and lot's of other WebappsTODO
Checklist
Haven't found any documentation of Keyboard Shortcuts, if there is any place to add this shortcut just let me know :)