fix(test): deactivate the deactivation of the contacts search provider #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
datenangebot
commented
Dec 5, 2023
datenangebot
commented
⁉️ have to clarify if the search provider will come back by default or not
added 2 commits
December 5, 2023 15:23
-⁉️ have to clarify if the search provider will come back by default or not Signed-off-by: Florian Steffens <[email protected]>
Signed-off-by: Florian Steffens <[email protected]>
|
This is actually an intended change from nextcloud/server#41738 so it only shows up if contacts is enabled as an app in the future |
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/cypress
branch
from
1f9db4f to
c6ac4af
Compare
|
Pushed some adjustments to make them all pass |
juliusknorr
approved these changes
Dec 7, 2023
enjeck
reviewed
Dec 7, 2023
| @@ -23,7 +23,7 @@ describe('Rows for a table', () => { | |||
| cy.get('.modal__content [aria-label="Increase stars"]').click().click() | |||
| cy.get('.modal-container button').contains('Save').click() | |||
|
|
|||
| cy.get('.modal-container').should('not.exist') | |||
| cy.get('.modal-container:visible').should('not.exist') | |||
| cy.get('.custom-table table').contains('My first task').should('exist') | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
I think the Create, Edit and Delete tests here are too coupled to each other, and one failing will impact the others. Imo, it'll be nice if they're made independent or combined into a single test.
|
Yes, very good points. We can try to improve the test cases whenever we adjust them next time 👍 |
|
Let's backport this to the stable branch as well as it also covers support for Nextcloud 28. |
|
/backport to stable0.6 |
backportbot-nextcloud
bot
added
the
backport-request
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.