Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use actual computed value for the URL #735

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: Use actual computed value for the URL #735

merged 1 commit into from
Dec 7, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 6, 2023

@datenangebot My guess is that you could not reproduce as you are using a http dev instance? It likely takes the other path which takes the url from the input instead of the computed which was called differently.

Fix #723

apiEndpointUrl() {
const params = {
elementId: this.activeElement.id,
}
const url = '/apps/tables/api/1/' + (this.isView ? 'views' : 'tables') + '/{elementId}'
return window.location.protocol + '//' + window.location.host + generateUrl(url, params)
},

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Dec 6, 2023
@juliusknorr
Copy link
Member Author

/backport to stable0.6

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Dec 6, 2023
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care "fixing" about all the warnings thrown by GitHub Actions / eslint and GitHub Actions / Nextcloud?

@juliusknorr
Copy link
Member Author

Do we care "fixing" about all the warnings thrown by GitHub Actions / eslint and GitHub Actions / Nextcloud?

Not necessarily in this pull request as it is unrelated to the bugfix, but would be good to get those warnings addressed as well of course to have a clean linting/static analysis output. Feel free to dive into that and open a separate PR.

Just a note, the Static analysis / Nextcloud which runs Psalm is probably worth to wait until @datenangebot wrapped up his refactoring on the database columns logic from #498

@juliusknorr
Copy link
Member Author

Rebased to have CI run again after #733

@juliusknorr juliusknorr requested a review from enjeck December 7, 2023 12:32
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I left a few comments on #733

@juliusknorr
Copy link
Member Author

Thanks, feel free to also press merge if approved and CI is happy :)

@juliusknorr juliusknorr merged commit 734e8f4 into main Dec 7, 2023
@juliusknorr juliusknorr deleted the bugfix/723 branch December 7, 2023 14:29
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy API-Endpoint link does not work
2 participants