-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use actual computed value for the URL #735
Conversation
/backport to stable0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care "fixing" about all the warnings thrown by GitHub Actions / eslint
and GitHub Actions / Nextcloud
?
Not necessarily in this pull request as it is unrelated to the bugfix, but would be good to get those warnings addressed as well of course to have a clean linting/static analysis output. Feel free to dive into that and open a separate PR. Just a note, the Static analysis / Nextcloud which runs Psalm is probably worth to wait until @datenangebot wrapped up his refactoring on the database columns logic from #498 |
Signed-off-by: Julius Härtl <[email protected]>
ccd4229
to
d817b98
Compare
Rebased to have CI run again after #733 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I left a few comments on #733
Thanks, feel free to also press merge if approved and CI is happy :) |
@datenangebot My guess is that you could not reproduce as you are using a http dev instance? It likely takes the other path which takes the url from the input instead of the computed which was called differently.
Fix #723
tables/src/modules/sidebar/sections/SidebarIntegration.vue
Lines 69 to 75 in ccd4229