Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more file extensions #394

Closed
The1AndMany opened this issue Nov 2, 2019 · 22 comments
Closed

Support more file extensions #394

The1AndMany opened this issue Nov 2, 2019 · 22 comments
Labels
enhancement New feature or request

Comments

@The1AndMany
Copy link

Is your feature request related to a problem? Please describe.
When I was using files_texteditor, it allowed me to open files with pretty much any file extension, so long as the data was stored in plaintext format. This was especially useful for editing my website's .html and .css files on the fly. Since upgrading to Nextcloud 17, this functionality seems to have been removed when the default text editor changed. This means I must have that file synced to my computer and open it locally, but there are some instances where I might be using a public computer at a library, so that wouldn't be an option.

Describe the solution you'd like
Ideally, if a file format stores its data in a plaintext-like format (.html, .css, .json, .xml, etc.), Text should be able to open it

Describe alternatives you've considered
Switch back to files_texteditor, but I'm not sure that's a possibility anymore

Additional context
The only other context I can think of is specifically stating that I keep my website saved to another folder on my server, which I connect to using local external storage.

@The1AndMany The1AndMany added the enhancement New feature or request label Nov 2, 2019
@gt2416
Copy link

gt2416 commented Nov 5, 2019

+1 for this, I used to be able to code my .cpp files on nextcloud for my school projects, now it just downloads the file.

@juliusknorr
Copy link
Member

As a quick fix we can extend the list in https://github.com/nextcloud/text/blob/master/src/helpers/mime.js#L38

Ideally the viewer should maybe also support wildcards just as the files apps file actions which also allows only matching for the mime part (text)

@FastBlit
Copy link

I would like to open asciidoc files without hiding the syntax.

@GottHeit
Copy link

GottHeit commented Dec 4, 2019

As a quick fix we can extend the list in https://github.com/nextcloud/text/blob/master/src/helpers/mime.js#L38

I tried to add that fix as I would like do edit some files which are not editable yet. But I don´t have that folder/file mentioned? Cannot find it, even with a search. Maybe you can give me a hint? (Not a nextcloud pro, so maybe too stupid ^^)

@juliusknorr
Copy link
Member

I tried to add that fix as I would like do edit some files which are not editable yet. But I don´t have that folder/file mentioned? Cannot find it, even with a search. Maybe you can give me a hint? (Not a nextcloud pro, so maybe too stupid ^^)

Those file are not available in the release bundle since we use webpack to bundle all files in the src/ directory into javascript bundles. Checkout the development setup in our readme: https://github.com/nextcloud/text#-development-setup

@Torenga
Copy link

Torenga commented Jul 16, 2020

Please make this an opt-in/out feature. I want to click my HTML-files, start a download and open them directly in a new tab. No hosting, no editing.

At the moment I have removed the Text app because it freezes the tab when opening larger HTML-files (10mb+) in the editor beyond blocking my workflow.

Edit: A workaround is editing MIME type handling, but it's hardly an end-user option so while the problem is fixed for me the request still stands. 👍

@ParaplegicRacehorse
Copy link

I don't much care about programming syntax -- a separate code editor app might be better suited for that -- but I think support for more general-purpose markup languages would be a good thing.

++ org-mode
++ asciidoc

I know gitlab and github web editors both have some level of support for at least org-mode and asciidoc. Code could be borrowed.

@juliusknorr
Copy link
Member

Pull requests are very welcome for that. As mentioned the mimetypes are listed in https://github.com/nextcloud/text/blob/master/src/helpers/mime.js#L38

@bzg
Copy link

bzg commented Oct 9, 2020

I'm the maintainer of Org-mode, let me know if we can help about this.

@juliusknorr
Copy link
Member

Is there a standardized mimetype for org files somewhere or should they be just considered as text/plain as it get it on my system:

$ file --mime-type test.org
test.org: text/plain

@bzg
Copy link

bzg commented Oct 9, 2020

We have a de facto mimetype text/org advertized on our website but it is not registered yet, we are working toward registering it. In the meantime, text/plain would be.

@JudicialDomicide
Copy link

Being able to edit .org and .bib files in nextcloud natively would be really useful rather than having to download to edit.

@ParaplegicRacehorse
Copy link

Nobody is asking for the full emacs org-mode interactive experience (it would be lovely, but way outside the scope of this issue). Simple recognition of file type, editability as any other plain text file, and display-rendering of the markup at least to the same level of sophistication that whichever flavor of markdown you recognize currently enjoys.

@Spartachetto
Copy link

@juliushaertl the request of the possibility to open other files formats with a text editor (either permanently or just in case you need it that time) has a long story.

Here are some references:
nextcloud/files_texteditor#15
nextcloud/files_texteditor#16

I'd add also this, as I think it is related:
nextcloud/viewer#2393

@JudicialDomicide
Copy link

JudicialDomicide commented Mar 2, 2021 via email

@Spartachetto
Copy link

@JudicialDomicide if you are disturbed by my comment, my purpose was:

  • to let the developers know that this feature is asked since long time
  • to help issue maintainers to close issues that could be no more useful
  • to link to interesting ideas like, for example, the possibility to provide both the ability to always open a specific file format with a text editor or to open it only if needed

So I ask to @juliushaertl to please tell me if i managed to reach at least some of these goals....

I'd also like to ask if @JudicialDomicide nice words respect Nextcloud code of conduct...

@zzkt
Copy link
Contributor

zzkt commented Mar 8, 2021

@bzg @JudicialDomicide (and others) as of Nextcloud 21 you can now view & edit .org files as text.

@JudicialDomicide
Copy link

JudicialDomicide commented Mar 8, 2021 via email

@zzkt
Copy link
Contributor

zzkt commented Mar 8, 2021

@JudicialDomicide you could try adding the relevant MIME info (i.e. application/x-bibtex) to the text app and nextcloud (e.g. nextcloud/server#1205)

@Thatoo
Copy link

Thatoo commented Jun 22, 2022

I guess, this could be solved by these two old enhancement requests : nextcloud/viewer#2393 and nextcloud/server#9192

Thus, I invite people of this thread to +1 these two requests and close this issue to make things clearer to devs.

@bzg
Copy link

bzg commented Jun 23, 2022

Thanks @Thatoo, I +1'ed the other two requests.

@juliusknorr
Copy link
Member

I'm going to close this as this is a very wide ticket. In case you want to push forward additional file type support, this would need:

  • The mime type needs to be known by Nextcloud server (see add text/org mimetype server#24488 for how this can be added)
  • Once that is there, please open a separate ticket for the individual types or a pull request to add them to

    text/src/helpers/mime.js

    Lines 35 to 61 in 12df66f

    const openMimetypesMarkdown = [
    'text/markdown',
    ]
    const openMimetypesPlainText = [
    'text/plain',
    'application/cmd',
    'application/x-empty',
    'application/x-msdos-program',
    'application/javascript',
    'application/json',
    'application/x-perl',
    'application/x-php',
    'application/x-tex',
    'application/xml',
    'application/yaml',
    'text/css',
    'text/html',
    'text/org',
    'text/x-c',
    'text/x-c++src',
    'text/x-h',
    'text/x-java-source',
    'text/x-ldif',
    'text/x-python',
    'text/x-shellscript',
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests