Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: open different mimetypes #3540

Merged
merged 1 commit into from
Dec 8, 2022
Merged

test: open different mimetypes #3540

merged 1 commit into from
Dec 8, 2022

Conversation

max-nextcloud
Copy link
Collaborator

Just text/plain and text/markdown for now.
Also provide some docs how to add more mimetypes to text. (taken from #394)

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Just `text/plain` and `text/markdown` for now.
Also provide some docs how to add more mimetypes to text.

Signed-off-by: Max <[email protected]>
@cypress
Copy link

cypress bot commented Dec 8, 2022



Test summary

111 0 0 0Flakiness 2


Run details

Project Text
Status Passed
Commit 0d01bbc
Started Dec 8, 2022 4:07 PM
Ended Dec 8, 2022 4:13 PM
Duration 06:25 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Flakiness

sections.spec.js Flakiness
1 Content Sections > Heading anchors > Anchor scrolls into view
links.spec.js Flakiness
1 test link marks > link preview > shows a link preview

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@juliusknorr juliusknorr merged commit 535fcbe into master Dec 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the test/mimetypes branch December 8, 2022 16:23
@bjornfor
Copy link
Contributor

bjornfor commented Dec 8, 2022

Also provide some docs how to add more mimetypes to text. (taken from #394)

Where? Is the test itself the documentation?

@max-nextcloud
Copy link
Collaborator Author

Where? Is the test itself the documentation?

Oh... good catch. I wish git comment --amend would warn me if i did not add anything to the commit. Will push the doc snippet in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants