Bump highlight.js from 10.7.3 to 11.3.1 #1942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azul
force-pushed
the
azul/update-highlight.js
branch
2 times, most recently
from
a14918f to
9801291
Compare
Use path to the node_modules folder to work around webpack/webpack#13865 Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.7.3 to 11.3.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md) - [Commits](highlightjs/highlight.js@10.7.3...11.3.1) --- updated-dependencies: - dependency-name: highlight.js dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
azul
force-pushed
the
azul/update-highlight.js
branch
from
9801291 to
bb991a8
Compare
azul
commented
Nov 9, 2021
Comment on lines
-51
to
+53
| const lang = await import(/* webpackChunkName: "highlight/[request]" */'highlight.js/lib/languages/' + languages[i]) | ||
| const lang = await import( | ||
| /* webpackChunkName: "highlight/[request]" */ | ||
| '../node_modules/highlight.js/lib/languages/' + languages[i]) |
There was a problem hiding this comment.
This is the actual workaround.
Not sure if that's viable for now.
|
Nice, seems to do the trick for the import 🎉 However when doing some further tests the Highlight plugin of tiptap-extensions seems to be bound to lowlight 1.x which is not compatible with highlight.js 11.x so the highlighting is still not working yet. Maybe manually pinning lowlight to 2.4 works fine. |
|
@juliushaertl good catch! I think we should just stick to highlight.js 10 series then and look into upgrading to tiptap 2 etc. |
This was referenced Nov 11, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use path to the node_modules folder to work around
webpack/webpack#13865
Bumps highlight.js from 10.7.3 to 11.3.1.
updated-dependencies:
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] [email protected]
Summary