Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESEQ2_NORM bugfix #226

Merged
merged 2 commits into from
Jan 23, 2024
Merged

DESEQ2_NORM bugfix #226

merged 2 commits into from
Jan 23, 2024

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Jan 18, 2024

DESEQ2_NOR is missing the gene_id_col in its modules.config entry which can cause an error; it's solved in this PR

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Jan 18, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit 56415b0

+| ✅ 164 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-23 15:37:52

@WackerO
Copy link
Collaborator Author

WackerO commented Jan 18, 2024

Note: Fix linting and Changelog after review

@WackerO WackerO requested a review from pinin4fjords January 22, 2024 09:51
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once you've appeased prettier)

@WackerO WackerO merged commit ed5a486 into nf-core:dev Jan 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants