Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with uncompressed FASTA files #309

Closed
tavareshugo opened this issue Sep 7, 2023 · 2 comments
Closed

Error with uncompressed FASTA files #309

tavareshugo opened this issue Sep 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@tavareshugo
Copy link
Contributor

tavareshugo commented Sep 7, 2023

Description of the bug

When supplying uncompressed FASTA files in the samplesheet, I now get an error:

Fasta file for reads must be provided, cannot contain spaces and must have extension '.fa.gz', '.fna.gz' or '.fasta.gz'

I've locally patched it by changing the regular expression in the schema_input.json:

^\\S+\\.f(ast|n)?a(\\.gz)?$

To make .gz optional.

In addition, I believe the current expression doesn't accept .fas, which is also sometimes used for FASTA files.
Perhaps the expression could be changed to:

^\\S+\\.(fasta|fas|fa|fna)(\\.gz)?$

Command used and terminal output

No response

Relevant files

No response

System information

No response

@tavareshugo tavareshugo added the bug Something isn't working label Sep 7, 2023
@jfy133
Copy link
Member

jfy133 commented Sep 12, 2023

Thanks @tavareshugo ! Much of the team is either on parental leave (myself) or at conferences this week, so we might be slow in replying currently!

The first is definitely a bug (from me, my bad!), if you've already patched it - would you be willing to open a PR?

The second also I agree would be worth supplying, but it would be important to test to make sure all the screening tools accept this as input (some are fickly with file naming...).

If you had time, would you be able to do this? Otherwise one of us can test once we are back next week :)

tavareshugo added a commit to tavareshugo/funcscan that referenced this issue Sep 18, 2023
tavareshugo added a commit to tavareshugo/funcscan that referenced this issue Oct 9, 2023
jasmezz added a commit that referenced this issue Oct 13, 2023
fix input schema to accept uncompressed fasta; fix #309
@jasmezz
Copy link
Collaborator

jasmezz commented Oct 13, 2023

Closed by #310

@jasmezz jasmezz closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants