-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook modules #617
Notebook modules #617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few open questions as a code review - would be great if I could get some feedback!
Asking additional review from @jianhong, who showed interest in such a module on slack. |
I added tests now, see the sister PR nf-core/test-datasets#297 in test-datasets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly formatting, one suggestion and one possible suggestion to remove debugging stuff if it's ready.
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
cc4db3d
to
c1b9234
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @grst ! Mostly minor comments. Feel free to merge when they have been addressed!
Co-authored-by: Harshil Patel <[email protected]>
Attempt to implement generic modules for rendering Rmarkdown or jupyter notebooks into HTML reports.
I'm deviating from the one module - one PR rule here, because I feel the two should be discussed together.
The modules support
PR checklist
<SOFTWARE>.version.txt
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd