Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook modules #617
Notebook modules #617
Changes from 8 commits
803bdbb
c32aab9
1bb979e
2578be2
45252df
d24be9a
d749782
7ff964e
2a5a147
2375450
ba3adb6
aff5e25
8195a2a
bfb0776
c7eb419
af8d617
38fa369
1c065ad
311d8e4
5232e6c
f48d159
51d6fb2
f71bd59
08e0d49
2fde477
7aadf4b
fdd2783
fe2706b
2add3ea
0b5f14a
64aae51
c9dc356
cba6f04
d4e9993
6f7ae10
54b4ad0
9ba1b87
dec9981
fdcc64c
560178c
7f99cda
ecf2a00
c1b9234
222d6c2
46cb8cb
38ad13d
807414a
653f5cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the rmd file contain sessionInfo section or not. if not add seesionInfo() at the end of rmd file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I like the idea of storing
sessionInfo
, I'm not a big fan of modifying the notebook. But maybe we can separately dump thesessionInfo
into a log file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sessionInfo might be overkill just for the rendering the notebook itself.
https://github.com/nf-core/modules#general
Might be sufficient? Or a some custom Rscript command to load the two packages and then run
sessionInfo()
andthen some bash cleanup?
Half completed example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I added a sessioninfo log as separate output.
Into the version.yml/versions.txt, I will only include the
rmarkdown
andyaml
packages which are directly needed for rendering the notebook.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfy133, this was the previous discussion... I think we agreed that all versions in the versions.yml is overkill, but I added a separate log file with the session info.