Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong version number in docs? #85

Closed
pareng opened this issue Sep 11, 2018 · 3 comments
Closed

Wrong version number in docs? #85

pareng opened this issue Sep 11, 2018 · 3 comments
Labels
documentation

Comments

@pareng
Copy link

pareng commented Sep 11, 2018

In several places, the documentation refers to v 1.4. I wonder if it should be 1.0 instead? Perhaps this aspect of the docs was not updated after moving from NGI to nf-core.

Docker hub does not have a version 1.4, only v1.0:
https://hub.docker.com/r/nfcore/rnaseq/tags/
ewels added a commit to ewels/nf-core-rnaseq that referenced this issue Sep 11, 2018
@ewels
Replace 1.4 for 1.0 in docs. Fixes nf-core#85
fee6ff4
@ewels ewels mentioned this issue Sep 11, 2018
Merged
ewels added a commit to ewels/nf-core-rnaseq that referenced this issue Sep 11, 2018
@ewels
Replace 1.4 for 1.0 in docs. Fixes nf-core#85
082d7b6
@ewels
Copy link
Member

ewels commented Sep 11, 2018

Thanks @pareng! Yes, you're absolutely correct - SciLifeLab/NGI-RNAseq got to version 1.4, then we restarted at 1.0 with the rebranded nf-core/rnaseq

Updated in #87 using a bit of find-and-replace. Let me know if I missed any.

ewels added a commit to ewels/nf-core-rnaseq that referenced this issue Sep 11, 2018
@ewels
Replace 1.4 for 1.0 in docs. Fixes nf-core#85
da58914
ewels added a commit to ewels/nf-core-rnaseq that referenced this issue Sep 11, 2018
@ewels
Replace 1.4 for 1.0 in docs. Fixes nf-core#85
6a06f9e
@ewels
Copy link
Member

ewels commented Sep 11, 2018

Damn, you can still see all of my rebased commits referencing this issue - caught redhanded! 😳

@ewels
Copy link
Member

ewels commented Sep 11, 2018

Fixed and merged into dev - let me know if you spot any I missed @pareng!

@ewels ewels closed this as completed Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ewels @pareng