Update outdated "fix" message from nf-core lint
#1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1263 +/- ##
=======================================
Coverage 67.39% 67.39%
=======================================
Files 50 50
Lines 5607 5607
=======================================
Hits 3779 3779
Misses 1828 1828
Continue to review full report at Codecov.
|
ewels
approved these changes
Aug 9, 2021
ewels
reviewed
Aug 9, 2021
| @@ -38,7 +38,9 @@ def print_fixes(lint_obj, module_lint_obj): | |||
| """Prints available and applied fixes""" | |||
|
|
|||
| if len(lint_obj.could_fix): | |||
| fix_cmd = "nf-core lint {} --fix {}".format(lint_obj.wf_path, " --fix ".join(lint_obj.could_fix)) | |||
| fix_cmd = "nf-core lint {}--fix {}".format( | |||
| "" if lint_obj.wf_path == "." else f"--dir {lint_obj.wf_path}", " --fix ".join(lint_obj.could_fix) | |||
There was a problem hiding this comment.
Could in theory just take the command used and append fixed I think. But not sure it's worth the effort, this looks good too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update "fix" message from
nf-core lintto conform to the current command line options. Should close #1259.PR checklist
CHANGELOG.mdis updateddocsis updated