Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update example dependencies to latest Angular version 13 release #3186

Closed
brandonroberts opened this issue Oct 18, 2021 · 11 comments · Fixed by #3269
Closed

Docs: update example dependencies to latest Angular version 13 release #3186

brandonroberts opened this issue Oct 18, 2021 · 11 comments · Fixed by #3269
Assignees
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs

Comments

@brandonroberts
Copy link
Member

Other information:

I would be willing to submit a PR for the docs ❤️

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@jordanpowell88
Copy link
Contributor

I'm happy to take this

jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Oct 25, 2021
@timdeschryver
Copy link
Member

Thanks @jordanpowell88 , feel free to take this.
Though maybe it would be better to wait on #3184.

@timdeschryver timdeschryver added Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs labels Nov 9, 2021
@jordanpowell88
Copy link
Contributor

Sounds great. I'll wait on #3184 first

@patelvimal
Copy link

@timdeschryver Does this issue still relevant? I guess required changes has been done in #3184.

@timdeschryver
Copy link
Member

@patelvimal yes it's still required. #3184 has updated the main repo with its libraries to v13, but we also have to update our examples on ngrx.io, which can be found here.

@patelvimal
Copy link

@timdeschryver thanks for the update. I can take this one and raise the PR.

@timdeschryver
Copy link
Member

Please check with @jordanpowell88 first.

@patelvimal
Copy link

@jordanpowell88 I can see you have already made the required changes in your commit.
Is there anything pending on that? Let me know if I can contribute in some way.

@jordanpowell88
Copy link
Contributor

Hey fellas, I was waiting for Nx to get updated, let me work on finishing this up. I'll reach out if I need any help @patelvimal !

@jordanpowell88
Copy link
Contributor

Can you assign to me @timdeschryver?

@timdeschryver
Copy link
Member

Sure, thanks @jordanpowell88

jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Dec 22, 2021
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Dec 22, 2021
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Dec 22, 2021
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Dec 23, 2021
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Dec 23, 2021
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Dec 27, 2021
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Dec 29, 2021
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Jan 5, 2022
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants