Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackblitz links are outdated #3261

Closed
cedricduffournet opened this issue Dec 6, 2021 · 9 comments · Fixed by #3321
Closed

Stackblitz links are outdated #3261

cedricduffournet opened this issue Dec 6, 2021 · 9 comments · Fixed by #3321
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs

Comments

@cedricduffournet
Copy link
Contributor

cedricduffournet commented Dec 6, 2021

The following stackblitz links are outdated:

@markostanimirovic
Copy link
Member

@cedricduffournet

There is already an open issue for examples: #3186

@timdeschryver
Copy link
Member

Does stackblitz work with Angular 13?

I'm getting the following error.
I also tried creating a new project (defaults to angular 12), and after upgrading it to v13 I also get this error.

@cedricduffournet
Copy link
Contributor Author

cedricduffournet commented Dec 6, 2021

Code example in angular doc seems to use WebContainer. On stackblitz dashboard you can create Node.js project (this is a beta version).
I created an example with ngrx : https://stackblitz.com/edit/node-v7anuw

@timdeschryver
Copy link
Member

Oh neat, thanks for the info @cedricduffournet, I did not know that 👍

@timdeschryver
Copy link
Member

Fyi, I've updated the ngrx-seed to v13.
For the example app, we'll have to verify that a web container project supports TS paths.

@cedricduffournet
Copy link
Contributor Author

@timdeschryver thank you for the ngrx-seed update.
I checked and web container supports paths configured in tsconfig.json (I think that's why this issue has been closed).
Quick example here : https://stackblitz.com/edit/node-l7ijlh?file=src%2Fmain.ts

@timdeschryver
Copy link
Member

@cedricduffournet Good to know!
Do you want investigate this further so that our example app also targets a webcontainer project?
Seems like it's documented, and that the Angular team already ported over their examples in this commit.

@cedricduffournet
Copy link
Contributor Author

@timdeschryver yes of course !

@timdeschryver timdeschryver added Accepting PRs community watch Someone from the community is working this issue/PR labels Jan 17, 2022
@timdeschryver
Copy link
Member

Thanks @cedricduffournet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants