Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use StackBlitz WebContainers for live examples #3321

Merged

Conversation

cedricduffournet
Copy link
Contributor

@cedricduffournet cedricduffournet commented Feb 18, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3261

What is the new behavior?

Target web containers in stackblitz live example (more info about stackblitz webcontainer here)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

  • took example on this PR in angular repo
  • this PR fix issue in store testing example (currently not working). Test are not executed automatically. Must execute yarn test command in webcontainer
  • I could now make some research on how we could make example-app working in stackblitz as webcontainers support TS paths (see discussion here)

@netlify
Copy link

netlify bot commented Feb 18, 2022

✔️ Deploy Preview for ngrx-io ready!
Built without sensitive environment variables

🔨 Explore the source changes: 76eb0f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/ngrx-io/deploys/62143189f5a4960007935af7

😎 Browse the preview: https://deploy-preview-3321--ngrx-io.netlify.app

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @cedricduffournet! 🥇

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @cedricduffournet and thanks for the cleanup!

@timdeschryver
Copy link
Member

Closing and re-opening to retrigger the CI

@markostanimirovic
Copy link
Member

Rebased onto the master branch to trigger circleci: test check.

@markostanimirovic markostanimirovic changed the title doc(example): target webcontainers in stackblitz docs: use StackBlitz WebContainers for live examples Feb 22, 2022
Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cedricduffournet!

Btw, the component-store-slide-toggle example also works again! 🎉

@markostanimirovic markostanimirovic merged commit 25cfd24 into ngrx:master Feb 22, 2022
@cedricduffournet
Copy link
Contributor Author

Nice ... I didn't know this example did not work

@cedricduffournet cedricduffournet deleted the webcontainer-stackblitz branch March 29, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stackblitz links are outdated
3 participants