-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use StackBlitz WebContainers for live examples #3321
docs: use StackBlitz WebContainers for live examples #3321
Conversation
✔️ Deploy Preview for ngrx-io ready! 🔨 Explore the source changes: 76eb0f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/ngrx-io/deploys/62143189f5a4960007935af7 😎 Browse the preview: https://deploy-preview-3321--ngrx-io.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @cedricduffournet! 🥇
9fbdbee
to
596018d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @cedricduffournet and thanks for the cleanup!
Closing and re-opening to retrigger the CI |
ae86582
to
76eb0f9
Compare
Rebased onto the master branch to trigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cedricduffournet!
Btw, the component-store-slide-toggle
example also works again! 🎉
Nice ... I didn't know this example did not work |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3261
What is the new behavior?
Target web containers in stackblitz live example (more info about stackblitz webcontainer here)
Does this PR introduce a breaking change?
Other information
yarn test
command in webcontainer