Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game_of_life example uses incorrect serviceClass format #849

Closed
bkeryan opened this issue Aug 28, 2024 · 2 comments · Fixed by #877
Closed

game_of_life example uses incorrect serviceClass format #849

bkeryan opened this issue Aug 28, 2024 · 2 comments · Fixed by #877
Assignees
Labels
bug Something isn't working triage New issue that needs to be reviewed

Comments

@bkeryan
Copy link
Collaborator

bkeryan commented Aug 28, 2024

Bug Report

The serviceClass should look like a gRPC service name (with an optional _Python suffix), but the game_of_life example uses snake_case.

Repro or Code Sample

https://github.com/search?q=repo%3Ani%2Fmeasurement-plugin-python%20serviceClass&type=code

Expected Behavior

"serviceClass": "ni.examples.GameOfLife_Python",

Current Behavior

"serviceClass": "game_of_life_Python",

Possible Solution

Rename it and update the .measui

Context

Measurement Client codegen derives module/class names from the service class.

Your Environment

  • OS & Device: Windows
  • ni-measurement-plugin-sdk-service version: 2.1 main
  • MeasurementLink version: 2024Q3
  • Python version: 3.9

AB#2841878

@bkeryan bkeryan added bug Something isn't working triage New issue that needs to be reviewed labels Aug 28, 2024
@dixonjoel
Copy link
Collaborator

@bkeryan This will break .sfp panels and other .measui files that people may already have. Are we ok with that?

@bkeryan
Copy link
Collaborator Author

bkeryan commented Sep 10, 2024

@bkeryan This will break .sfp panels and other .measui files that people may already have. Are we ok with that?

Yes. Examples are allowed to break compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage New issue that needs to be reviewed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants