Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service class of Game of Life example #877

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Update service class of Game of Life example #877

merged 1 commit into from
Sep 10, 2024

Conversation

dixonjoel
Copy link
Collaborator

What does this Pull Request accomplish?

Fixes #849

Why should this Pull Request be merged?

Make Game of Life consistent with other examples

What testing has been done?

Interactive to ensure the service still works.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Test Results

    30 files  ±0      30 suites  ±0   39m 20s ⏱️ -1s
   651 tests ±0     651 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 130 runs  ±0  15 060 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit 8e6b367. ± Comparison against base commit 5974af6.

@dixonjoel dixonjoel merged commit 673cb23 into main Sep 10, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/fix-game-of-life-service-class branch September 10, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeryan bkeryan bkeryan approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

game_of_life example uses incorrect serviceClass format
2 participants
@dixonjoel @bkeryan