Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .serviceignore files to the examples #784

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

nick-beer
Copy link
Collaborator

@nick-beer nick-beer commented Jul 10, 2024

What does this Pull Request accomplish?

This PR adds .serviceignore files to each of the examples in preparation of the Plug-in Library release.

Why should this Pull Request be merged?

When publishing a plugin to a Plug-in Library, we should exclude the .venv folder and the __pycache__ folder if they are present. The presence of the .serviceignore file will instruct the Plug-in Library CLI to ignore these folders.

What testing has been done?

Verified that when publishing one of the examples to a Plug-in Library, we ignore these two folders.

Note
This PR should not be completed prior to the upcoming release of Plug-in Library.

Copy link

Test Results

   10 files  ±0     10 suites  ±0   31m 37s ⏱️ +7s
  653 tests ±0    653 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 390 runs  ±0  6 390 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8f5de84. ± Comparison against base commit 267ea0c.

@dixonjoel
Copy link
Collaborator

dixonjoel commented Jul 11, 2024

@nick-beer @bkeryan Since the repo was greatly reorganized yesterday, I'm going to make another prerelease. If we don't want this in the prerelease or the final release, I'll make them both out of the releases/2.0 branch and not cherry-pick this PR until we're ready for the final release. Any problems you see with that?

If we do it that way, you can go ahead and submit this to main.

@nick-beer
Copy link
Collaborator Author

@nick-beer @bkeryan Since the repo was greatly reorganized yesterday, I'm going to make another prerelease. If we don't want this in the prerelease or the final release, I'll make them both out of the releases/2.0 branch and not cherry-pick this PR until we're ready for the final release. Any problems you see with that?

If we do it that way, you can go ahead and submit this to main.

@dixonjoel - Not sure I know enough about the processes in this repo to meaningfully reply. I'm fine with however you decide to handle it. FYI, I've got one more change like this coming to this repo.

@dixonjoel dixonjoel merged commit 1c7607a into main Jul 11, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/nbeer/service-ignore branch July 11, 2024 19:07
dixonjoel added a commit that referenced this pull request Jul 11, 2024
#791)

Add .serviceignore files to the examples (#784)

Co-authored-by: Nick Beer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants