[releases/2.0]: Cherry-pick 'Add .serviceignore files to the examples' #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixonjoel
requested review from
csjall,
bkeryan,
nstokes-nati and
mshafer-NI
as code owners
|
Does this belong in 2.0? @nick-beer wrote this in #784
|
@bkeryan - Yes, I believe it does. I talked with Joel about this offline. I just want to make sure it goes with whatever we just completed for C2. |
bkeryan
approved these changes
Jul 11, 2024
|
@bkeryan I don't know why the checks are not running. I'm going to create a new PR with this branch. |
|
Not running checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Cherry-pick "Add .serviceignore files to the examples" commit from main.
Why should this Pull Request be merged?
Needed for releases / 2.0
What testing has been done?
None - straight cherry-pick