Numerous fixes mostly related to HA Auto Discovery, Temperature Sensors, and Timers #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the Auto Discovery Temperature Sensor issue wherein the sensors were not being deleted if removed from the Network Module. Now a more complete Auto Discovery sequence occurs when the Network Module reconnects with HA.
This code is broken at the moment. Uploading for collaboration test.
Fixed bugs with the new Serial Number based Temperature Sensor IDs.
Added the ability to add/delete temperatre sensor devices and have them automatically update in the Browser and on MQTT (HA/AutoDiscovery)
Fixed Issue #55: Home Assistant; Auto Discovery; MQTT; Temp Sensors do not get deleted and redefined properly when added/removed Fixed Issue #56: Temperature Sensor accuracy improvement Fixed Issue #57: Temperature sensor order in GUI and Home Assistant. Fixed by changing Temperature Sensor ID’s from “1, 2, 3, 4, 5” to a 12 character ID per sensor that is based on the sensor serial number Fixed Issue #58: Home Assistant; Auto Discovery; MQTT; Should a temperature sensor be deleted in HA if it fails during runtime? Fixed Issue #62: Browser Only; Timers don’t work with Invert setting. Included in fix is a correction for “Timer values not saved correctly” and “Timer value being set to 256 in error”. Fixed Issue #63: REST commands preventing IO Control page from making pin state changes. Fixed Issue #66: MQTT doesn’t report temperature sensors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committing numerous fixes in preparation for release
o Fixed Issue #55: Home Assistant; Auto Discovery; MQTT; Temp Sensors do not get deleted and redefined properly when added/removed
o Fixed Issue #56: Temperature Sensor accuracy improvement
o Fixed Issue #57: Temperature sensor order in GUI and Home Assistant. Fixed by changing Temperature Sensor ID’s from “1, 2, 3, 4, 5” to a 12 character ID per sensor that is based on the sensor serial number
o Fixed Issue #58: Home Assistant; Auto Discovery; MQTT; Should a temperature sensor be deleted in HA if it fails during runtime?
o Fixed Issue #62: Browser Only; Timers don’t work with Invert setting. Included in fix is a correction for “Timer values not saved correctly” and “Timer value being set to 256 in error”.
o Fixed Issue #63: REST commands preventing IO Control page from making pin state changes.
o Fixed Issue #66: MQTT doesn’t report temperature sensors unless at least 1 IO is enabled.