Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for camunda extension "Escape variable names"? #36

Closed
makepanic opened this issue Jul 30, 2024 · 2 comments · Fixed by #37
Closed

Support for camunda extension "Escape variable names"? #36

makepanic opened this issue Jul 30, 2024 · 2 comments · Fixed by #37
Labels
enhancement New feature or request

Comments

@makepanic
Copy link
Contributor

Is your feature request related to a problem? Please describe

Hi,
thanks for maintaining this great grammar for feel.
I'm wondering if it should also support escaped variables via backticks as defined in the feel guides: https://docs.camunda.io/docs/components/modeler/feel/language-guide/feel-variables/#escape-variable-names

I know it's marked as camunda extension but should the tokenizer also detect these as VariableName?
Right now it just errors. This also happens in the camunda modeler.

Describe the solution you'd like

`first name`

`tracking-id`

order.`total price`

should output VariableName tokens without errors.

Describe alternatives you've considered

Fork this library and add support for the camunda extension which might not be intended to be included in the base grammar.

Additional context

20240730-160811

@makepanic makepanic added the enhancement New feature or request label Jul 30, 2024
makepanic added a commit to makepanic/lezer-feel that referenced this issue Aug 21, 2024
@nikku
Copy link
Owner

nikku commented Aug 21, 2024

Thanks for the issue. This repository is not the right place for such an extension. But we actively discuss a @camunda fork, allowing us to implement Camunda-specific quirks there.

@nikku
Copy link
Owner

nikku commented Aug 21, 2024

What we could do, of course, is to implement this as a grammar dialect, i.e. camunda.

makepanic added a commit to makepanic/lezer-feel that referenced this issue Aug 21, 2024
makepanic added a commit to makepanic/lezer-feel that referenced this issue Aug 21, 2024
nikku pushed a commit to makepanic/lezer-feel that referenced this issue Aug 21, 2024
* Adds `camunda` dialect
* Adds support for backtick escaped variables, i.e. foo.`boo ba`
* Must be explicitly enabled via `camunda` dialect

Closes nikku#36
@nikku nikku closed this as completed in ee59237 Aug 21, 2024
@nikku nikku closed this as completed in #37 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants