Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the [Processing] messages into dots #14418

Merged
merged 3 commits into from
May 21, 2020
Merged

change the [Processing] messages into dots #14418

merged 3 commits into from
May 21, 2020

Conversation

Araq
Copy link
Member

@Araq Araq commented May 21, 2020

No description provided.

@mratsim
Copy link
Collaborator

mratsim commented May 21, 2020

Is there a reason for this?

I've had the compiler suddenly quit 0 on me with no error message and the hint was helpful to narrow down a minimal reproducing example.

@Araq
Copy link
Member Author

Araq commented May 21, 2020

I've had the compiler suddenly quit 0 on me with no error message and the hint was helpful to narrow down a minimal reproducing example.

Well we have --verbosity:2 or similar for that.

@Araq Araq merged commit ddee8a3 into devel May 21, 2020
@Araq Araq deleted the araq-dots branch May 21, 2020 20:36
@ghost
Copy link

ghost commented May 21, 2020

A small bug - if there are no warnings when compiling, there's no newline before the first "CC" message:

@timotheecour
Copy link
Member

timotheecour commented May 23, 2020

@Yardanico did #14415 fix your issue? I'm not seeing it after that PR

nim c --gc:arc -d:danger -r --hint:cc --listcmd:off --hint:conf -f $timn_test_hello_F
Hint: used config file '/Users/timothee/git_clone/nim/Nim_devel/config/nim.cfg' [Conf]
Hint: used config file '/Users/timothee/git_clone/nim/Nim_devel/config/config.nims' [Conf]
Hint: used config file '/Users/timothee/.config/nim/nim.cfg' [Conf]
Hint: used config file '/Users/timothee/.config/nim/config.nims' [Conf]
Hint: used config file '/Users/timothee/git_clone/nim/timn/nim.cfg' [Conf]
Hint: used config file '/Users/timothee/git_clone/nim/timn/config.nims' [Conf]
compiling /Users/timothee/git_clone/nim/timn/src/timn/examples/thello.nim
CC: stdlib_io.nim
CC: stdlib_system.nim
CC: thello.nim
Hint: 82917 lines; 0.482s; 95.363MiB peakmem; Dangerous Release build; proj: /Users/timothee/git_clone/nim/timn/src/timn/examples/thello.nim; out: /Users/timothee/git_clone/nim/timn/src/timn/examples/thello [SuccessX]
hello world

using nim c61f746 1.3.5

@mratsim

I've had the compiler suddenly quit 0 on me with no error message and the hint was helpful to narrow down a minimal reproducing example.

--hint:msgorigin should help (should work with all commands as of #14415)

that being said, I recently had cases where I wanted to see full path of files as they were being processed to debug which file was actually picked up (common case when you're debugging --path issues);

instead of using a ., for systems that support ansii escape sequences (posix + windows 10), there's a better alternative: write the full path, then erase the line using exact same logic as flushDot

this would be a strict improvement; however it still doesn't help if you need to see prior paths, not just last one; I'm scratching my head real hard for how to allow that without introducing a new flag (maybe -d:nimHintProcessingFullPath doesn't count as a new flag?)

@ghost
Copy link

ghost commented May 23, 2020

@timotheecour seems like it didn't help (no newline before first CC with no arguments, the nim.cfg just contains threads:on)

EchoPouet pushed a commit to EchoPouet/Nim that referenced this pull request Jun 13, 2020
* change the [Processing] messages into dots

* better implementation

* maybe I should work on something else...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants