-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erasable log lines #14438
Erasable log lines #14438
Conversation
0846e9f
to
e891fdc
Compare
Please use Descriptive titles, even if WIP. |
To add to @juancarlospaco comment, you don't need to include "WIP" in the title if its a draft PR anyways :) |
long story short, this fixes the following:
so this PR instead turns them into erasable lines; it's tricker than it seems because of line wrapping for long lines, so the API needs to be aware of how many lines to erase, which I handle in this PR; it's actually a generally useful API so the goal is to (eventually, not in this PR) expose it
This works, at least on OSX (including with long lines that wrap in terminal), feel free to try it out (well, despite the CI failures which I need to fix), but I'm still trying to figure out the right way to expose this because some valid use cases want to view full lines (without erasing and without dots); so the trivial option is to add a flag but there's some push for slowing down introduction of new flags, hence the difficulty here. a known caveat (which also affects |
This pull request has been automatically marked as stale because it has not had recent activity. If you think it is still a valid PR, please rebase it on the latest devel; otherwise it will be closed. Thank you for your contributions. |
No description provided.