Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redisqlite #7

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Redisqlite #7

wants to merge 25 commits into from

Conversation

sciabarracom
Copy link

Implementing API for redisqlite.

package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
redisqlite.js Outdated Show resolved Hide resolved
@jthomas
Copy link
Contributor

jthomas commented May 18, 2021

I'd need more information to understand this PR, will ping you.

README.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
Copy link
Contributor

@jthomas jthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const all the vars please :)

redisqlite.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@sciabarracom sciabarracom requested a review from jthomas May 23, 2021 11:21
Copy link
Contributor

@jthomas jthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good just one final thing to fix!

index.js Show resolved Hide resolved
@rabbah rabbah self-requested a review May 25, 2021 08:52
@jthomas
Copy link
Contributor

jthomas commented Jul 12, 2021

Any comments before merging @rabbah?

@rabbah
Copy link
Contributor

rabbah commented Jul 13, 2021

Will review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants