Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to manage secrets with Github Environments for Staging and Production #226

Closed
Tracked by #228
luongvo opened this issue Jul 10, 2023 · 0 comments · Fixed by #263
Closed
Tracked by #228

Update to manage secrets with Github Environments for Staging and Production #226

luongvo opened this issue Jul 10, 2023 · 0 comments · Fixed by #263
Assignees
Milestone

Comments

@luongvo
Copy link
Member

luongvo commented Jul 10, 2023

Why

Currently, both the root template and template project manage to define all variables for GitHub workflows for both Production and Staging env in the same place Secrets > Action. Hence, we must manually name these variables with _PRODUCTION or _STAGING postfixes and can not really know which one belongs to each env or is being shared between them.

image

GitHub supports a feature to manage them in each environment called Environments. We should follow this approach to define them wisely.

  • Variables belonging to the app build will be moved to Environments.
  • Variables only be used for the workflow in both env will be kept in Secrets > Action.

Who Benefits?

Developers

@luongvo luongvo self-assigned this Jul 21, 2023
@luongvo luongvo added this to the 1.11.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant